ARROW-1980: [Python] Fix race condition in write_to_dataset #1468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrist
commented
Jan 9, 2018
python/pyarrow/parquet.py
Outdated
Contributor
Author
There was a problem hiding this comment.
It might be worth adding exist_ok to the filesystem interface. Python has this kwarg for os.makedirs (but not os.mkdir) to say not to error if the directory already exists (defaults to False).
Member
There was a problem hiding this comment.
Before adding more things to the interface, I would prefer that we continue to settle the discussion on a uniform file interface between dask, Arrow and others. Then we actually know to what we all want to converge to.
Member
There was a problem hiding this comment.
Maybe worth opening a JIRA about this in either case
One race condition was already fixed, but another one exists when writing by partition.
jcrist
force-pushed
the
fix-race-condition-parquet-partition
branch
from
64d9bff to
180c4a2
Compare
xhochy
approved these changes
Jan 10, 2018
xhochy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One race condition was already fixed, but another one exists when
writing by partition.